From b714ae02a8ea1ba4e870a78ccfe1c9bc940718d9 Mon Sep 17 00:00:00 2001 From: Matthew Daley Date: Fri, 1 Nov 2013 13:30:44 +1300 Subject: [PATCH] libxl: check for xc_domain_shutdown failure in libxl__domain_suspend_common_callback Coverity-ID: 1055048 Signed-off-by: Matthew Daley Reviewed-by: Andrew Cooper Acked-by: Ian Campbell --- tools/libxl/libxl_dom.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index c164469a07..1812bdc079 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -1041,7 +1041,11 @@ int libxl__domain_suspend_common_callback(void *user) if (dss->hvm && (!hvm_pvdrv || hvm_s_state)) { LOG(DEBUG, "Calling xc_domain_shutdown on HVM domain"); - xc_domain_shutdown(CTX->xch, domid, SHUTDOWN_suspend); + ret = xc_domain_shutdown(CTX->xch, domid, SHUTDOWN_suspend); + if (ret < 0) { + LOGE(ERROR, "xc_domain_shutdown failed"); + return 0; + } /* The guest does not (need to) respond to this sort of request. */ dss->guest_responded = 1; } else { -- 2.30.2